partkeepr

commit 0e329e8156986d0edbc7af99033296d29136cc08
parent da9ea5635aee4a590ca108b7ffe448c9673a9a37
Author: Felicia Hummel <felicitus@felicitus.org>
Date:   Tue,  2 Aug 2016 19:39:41 +0200

Merge pull request #701 from partkeepr/PartKeepr-693

Return proper HTML for the flag icon, fixes #693
Diffstat:
M
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartsGrid.js
 | 
8
++++----

1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartsGrid.js b/src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartsGrid.js
@@ -43,7 +43,7 @@ Ext.define('PartKeepr.PartsGrid', {
 
     /**
      * Configure drag'n'drop.
-     * @todo Check if this messes up with the Part Dropdown in the project view
+     * @todo Check if this messes up with the Part drop down in the project view
      */
     viewConfig: {
         plugins: {
@@ -172,8 +172,6 @@ Ext.define('PartKeepr.PartsGrid', {
      *
      * Right now, this is hardcoded to alt+x.
      *
-     * @param none
-     * @return nothing
      */
     mapSearchHotkey: function ()
     {
@@ -368,8 +366,9 @@ Ext.define('PartKeepr.PartsGrid', {
     reviewRenderer: function (val, q, rec)
     {
         var ret = "";
+
         if (rec.get("needsReview") === true) {
-            ret += '<span class="web-icon flag_orange"' + '" title="' + i18n("Needs review") + '"></span>';
+            ret += '<span class="web-icon flag_orange" title="' + i18n("Needs review") + '"></span>';
         }
 
         return ret;
@@ -391,6 +390,7 @@ Ext.define('PartKeepr.PartsGrid', {
     /**
      * Handles editing of the grid fields. Right now, only the stock level editing is supported.
      *
+     * @param editor Not used
      * @param e An edit event, as documented in
      *            http://docs.sencha.com/ext-js/4-0/#!/api/Ext.grid.plugin.CellEditing-event-edit
      */