partkeepr

commit 8a6380e46efc81fd52c650995ad4ab62b7cbcedf
parent e10c6f3005df261037b298ed705b0b9148ce0e76
Author: Felicia Hummel <felicia@drachenkatze.org>
Date:   Fri, 20 Jul 2018 16:25:41 +0200

Merge remote-tracking branch 'origin/master'

Diffstat:
M
CONTRIBUTING.md
 | 
8
++++++++
M
src/PartKeepr/ProjectBundle/Entity/Report.php
 | 
6
+++++-

2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -11,6 +11,14 @@ Guidelines:
  * Try to reproduce the problem on [demo.partkeepr.org](https://demo.partkeepr.org) prior reporting the issue and indicate in the issue that you have done so
  * Report your __browser type and version__, any __JavaScript errors in the console__ and any other details like __server operating system__, __php version__, __SQL Server type and version__ etc.
 * Check your logs, especially your __Web Server Log__ as well as __app/logs/partkeepr.log__
+* Only attach the parts of the logs which are __relevant__ to the problem.
+* Make sure the problem is __reproducable__. If it only happened one time, you have to find out on how to reproduce it.
+* Explain, in simple words, __when__ the issue occured. For example: Don't write "I can't create a part". Rather write: "I clicked on Add Part, entered a Part Name, then I clicked the save button, then nothing happens. There were no JavaScript errors in the console, and no HTTP Request was sent."
+* Try to limit your bug report to only __essential__ steps on how to reproduce the issue.
+* In short, help the volunteers maintaining the project to spend as little effort as possible on the issue, so that we can have more time adding features and fixing bugs more easily.
+
+For further reading have a look at https://www.softwaretestinghelp.com/how-to-write-good-bug-report/ on how to write good bug reports.
+
 
 Use the dedicated mailing list or IRC for general questions as described on the [PartKeepr Support Page](https://www.partkeepr.org/support/).
 
diff --git a/src/PartKeepr/ProjectBundle/Entity/Report.php b/src/PartKeepr/ProjectBundle/Entity/Report.php
@@ -103,7 +103,11 @@ class Report extends BaseEntity
      */
     public function setName($name)
     {
-        $this->name = $name;
+        if ($name != null) {
+            $this->name = $name;
+        } else {
+            $this->name = 'NewReport'; //@todo i18n
+        }
 
         return $this;
     }